Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: use iota-sdk and remove dependency causing security alert #1247

Merged
merged 9 commits into from
Sep 12, 2023

Conversation

DaughterOfMars
Copy link
Collaborator

Linked Issues

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

API Changes

  • Test the API endpoints which were added/changed.
  • Ensure that the API response times scale with database size appropriately.
  • Review the API documentation changes and confirm that it matches the actual functionality.
  • Check for breaking changes in the API and matching (conventional) commit message prefix.

Test cases

  • Suggest places that may benefit from test cases.

Database Changes

  • Check for breaking changes in the data model and matching (conventional) commit message prefix.

Sorry, something went wrong.

Alex Coats added 3 commits August 15, 2023 08:55

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
Alexandcoats added 3 commits August 24, 2023 14:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Unverified

No user is associated with the committer email.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Alex6323
Copy link
Collaborator

Alex6323 commented Sep 10, 2023

Not entirely sure what lints replace it, but probably just remove the private_in_public lint. Otherwise I couldn't find any issues with this PR.

Alex Coats added 2 commits September 11, 2023 08:44

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
Alex6323
Alex6323 previously approved these changes Sep 12, 2023

Unverified

No user is associated with the committer email.
@DaughterOfMars DaughterOfMars merged commit 02f0e0b into main Sep 12, 2023
@DaughterOfMars DaughterOfMars deleted the chore/update-dependencies branch September 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2022-0093: Double Public Key Signing Function Oracle Attack on ed25519-dalek
2 participants